Add support for optimistic writes #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thruflo
requested changes
Mar 24, 2025
Contributor
thruflo
left a comment
thruflo
left a comment
There was a problem hiding this comment.
Super cool to see this. I've left a few comments about the documentation. I'm happy to do a pass on it if useful but perhaps we can discuss first.
This was referenced Apr 3, 2025
remove comments
move docs for plug_opts to top-level
so we can get custom errors
@magnetised I've done a pass on the docs. I'm afraid that it does include renaming preflight to check and Changeset to validate. Give it a read with an open mind -- for me this is far clearer naming. https://funny-sable-3d7d09.netlify.app/readme.html https://funny-sable-3d7d09.netlify.app/phoenix.sync.writer --------- Co-authored-by: Garry Hill <[email protected]>
which applies the transaction and returns the txid
and document the behaviour
also expose `parse_transaction/2`
Contributor
|
@magnetised I've had a pass on the docs as per https://funny-sable-3d7d09.netlify.app / https://funny-sable-3d7d09.netlify.app/phoenix.sync.writer Let me know any feedback. Otherwise are we close to being ready to merge this? |
Contributor
Author
|
@thruflo looks good! think we might be there |
Contributor
|
Merged -- we can still fine tune on other PRs. E.g.: match the TanStack/db rename. |
Contributor
|
Presumably we should do a release -- perhaps after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically supporting https://github.com/TanStack/optimistic